Github user tgravescs commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10475#discussion_r53174906
  
    --- Diff: 
yarn/src/main/scala/org/apache/spark/deploy/yarn/ExecutorDelegationTokenUpdater.scala
 ---
    @@ -76,7 +76,8 @@ private[spark] class ExecutorDelegationTokenUpdater(
             SparkHadoopUtil.get.getTimeFromNowToRenewal(
               sparkConf, 0.8, 
UserGroupInformation.getCurrentUser.getCredentials)
           if (timeFromNowToRenewal <= 0) {
    -        executorUpdaterRunnable.run()
    +        // Wait a minutes to avoid cycle calling this method.
    --- End diff --
    
    Can you change this comment to be a bit more clear something like:
    
    We just checked for new credentials but none were there, wait a minute and 
retry.  This handles the shutdown case where the staging directory may have 
been removed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to