Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/11249#discussion_r53417873
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/StreamingContext.scala ---
@@ -269,6 +270,39 @@ class StreamingContext private[streaming] (
RDDOperationScope.withScope(sc, name, allowNesting = false,
ignoreParent = false)(body)
}
+ private[streaming] val recoverableAccuNameToId: mutable.Map[String,
Long] = {
--- End diff --
I don't think the memory space is the problem, as in Java collection always
stores object references, not the real duplicated objects.
The reason I suggested to do that is to simplify the code at
https://github.com/apache/spark/pull/11249/files#diff-f0064bc8820551c338276e29d922e459R47
, which mean we don't need to get the Accumulator again by accumulator ids,
particularly the `Accumulators.originals` stores the `WeakReference` object, it
can return null.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
