Github user zsxwing commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10089#discussion_r53426791
  
    --- Diff: 
external/kafka/src/test/scala/org/apache/spark/streaming/kafka/DirectKafkaStreamSuite.scala
 ---
    @@ -430,6 +457,27 @@ class DirectKafkaStreamSuite
           rdd.asInstanceOf[KafkaRDD[K, V, _, _, (K, V)]].offsetRanges
         }.toSeq.sortBy { _._1 }
       }
    +
    +  private def getDirectKafkaStream(topic: String, mockRateController: 
Option[RateController]) = {
    +    val batchIntervalMilliseconds = 100
    +
    +    val sparkConf = new SparkConf()
    +      // Safe, even with streaming, because we're using the direct API.
    --- End diff --
    
    Remove this comment. It's a bit misleading. Since the tests won't start the 
StreamingContext, the core number is irrelevant.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to