Github user tgravescs commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11259#discussion_r53471628
  
    --- Diff: core/src/main/resources/org/apache/spark/ui/static/historypage.js 
---
    @@ -37,6 +37,22 @@ function formatDuration(milliseconds) {
       return hours.toFixed(1) + " h";
     }
     
    +function makeIdNumeric(id) {
    +  var strs = id.split("-");
    +  if (strs.length < 3) {
    +    return id;
    +  }
    +  var appSeqNum = strs[2];
    +  var resl = strs[0] + "-" + strs[1] + "-";
    +  var diff = 10 - appSeqNum.length;
    +  while (diff > 0) {
    --- End diff --
    
    we should at least comment this.  If java script has a function to pad or 
print strings it certain length it would be better.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to