Github user chenghao-intel commented on the pull request:
https://github.com/apache/spark/pull/1448#issuecomment-49823561
Generally the code looks good to me, except some of the potential
performance issues. And this actually supports all of the `JoinType` and the
`BuildSide`, it would be nicer if a complete unit tests added.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
