Github user tnachen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8872#discussion_r53531469
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala
---
@@ -452,38 +456,42 @@ private[spark] class MesosClusterScheduler(
* This method takes all the possible candidates and attempt to schedule
them with Mesos offers.
* Every time a new task is scheduled, the afterLaunchCallback is called
to perform post scheduled
* logic on each task.
+ *
+ * @return tasks Remaining resources after scheduling tasks
*/
private def scheduleTasks(
candidates: Seq[MesosDriverDescription],
afterLaunchCallback: (String) => Boolean,
- currentOffers: List[ResourceOffer],
- tasks: mutable.HashMap[OfferID, ArrayBuffer[TaskInfo]]): Unit = {
+ currentOffers: JList[ResourceOffer],
--- End diff --
Ah yes I originally changed it because we changed the MesosSchedulerUtils
return type as I rebased, but realized now I don't have to. I'm fixing it now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
