Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11190#discussion_r53545044
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala 
---
    @@ -2105,6 +2105,22 @@ class SQLQuerySuite extends QueryTest with 
SharedSQLContext {
         assert(error.getMessage contains "grouping_id() can only be used with 
GroupingSets/Cube/Rollup")
       }
     
    +  test("uncorrelated scalar subquery") {
    --- End diff --
    
    About test coverage:
    
    let's create a subquery suite and move the test cases there.
    
    Also it would be great to have at least once test case that actually runs 
on a dataset that is not generated by just select x, because I worry in the 
future we add some special optimizations and then all the test cases here 
become no-op.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to