Github user zsxwing commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1328#discussion_r15268635
  
    --- Diff: core/src/main/scala/org/apache/spark/MapOutputTracker.scala ---
    @@ -340,6 +459,7 @@ private[spark] class MapOutputTrackerMaster(conf: 
SparkConf)
      */
     private[spark] class MapOutputTrackerWorker(conf: SparkConf) extends 
MapOutputTracker(conf) {
       protected val mapStatuses = new HashMap[Int, Array[MapStatus]]
    +    with mutable.SynchronizedMap[Int, Array[MapStatus]]
    --- End diff --
    
    > Maybe it's better to make it ConcurrentHashMap in the base class.
    
    Because MapOutputTrackerMaster uses TimeStampedHashMap which is not a 
ConcurrentHashMap, MapOutputTracker still needs to use Map. Nevertheless, I can 
add a comment on MapOutputTracker.mapStatuses to mark that it should be a 
thread-safe map.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to