Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11223#discussion_r53547600
  
    --- Diff: dev/deps/spark-deps-hadoop-2.2 ---
    @@ -85,25 +89,41 @@ jackson-core-2.5.3.jar
     jackson-core-asl-1.9.13.jar
     jackson-databind-2.5.3.jar
     jackson-jaxrs-1.9.13.jar
    +jackson-jaxrs-base-2.5.4.jar
    +jackson-jaxrs-json-provider-2.5.4.jar
     jackson-mapper-asl-1.9.13.jar
    +jackson-module-jaxb-annotations-2.5.4.jar
     jackson-module-scala_2.11-2.5.3.jar
     jackson-xc-1.9.13.jar
     janino-2.7.8.jar
    +javassist-3.18.1-GA.jar
    +javax.annotation-api-1.2.jar
     javax.inject-1.jar
    +javax.inject-2.4.0-b31.jar
     javax.servlet-3.0.0.v201112011016.jar
     javax.servlet-3.1.jar
     javax.servlet-api-3.0.1.jar
    +javax.ws.rs-api-2.0.1.jar
     javolution-5.5.1.jar
     jaxb-api-2.2.2.jar
     jaxb-impl-2.2.3-1.jar
     jcl-over-slf4j-1.7.10.jar
     jdo-api-3.0.1.jar
     jersey-client-1.9.jar
    +jersey-client-2.22.1.jar
    --- End diff --
    
    Yeah, we have some Jersey and Jackson version problems here. Some Jackson 
deps are 1.9 some are 2.5. It's annoying but I think we would have to 
meticulously harmonize it. Jersey likewise... I'm assuming these are *not* the 
Sun jersey jars that appear as version 1.9? The `javax.inject` duplication 
would ideally be resolved too.
    
    The additions themselves don't look too bad.
    
    Do the Sun jersey classes belong to a different namespace? then I think we 
may need to not exclude them (but not use them) since they may be present for 
third party libs.
    
    Overall, I like updating things like this for a major release, though I 
don't yet fully have my head around the implications at runtime, where another 
Jackson version or Jersey version might turn up.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to