Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/11250#discussion_r53565164
--- Diff:
streaming/src/test/scala/org/apache/spark/streaming/CheckpointSuite.scala ---
@@ -613,7 +613,8 @@ class CheckpointSuite extends TestSuiteBase with
DStreamCheckpointTester
def recordedFiles(ssc: StreamingContext): Seq[Int] = {
val fileInputDStream =
ssc.graph.getInputStreams().head.asInstanceOf[FileInputDStream[_,
_, _]]
- val filenames =
fileInputDStream.batchTimeToSelectedFiles.values.flatten
+ val filenames =
fileInputDStream.batchTimeToSelectedFiles.synchronized
--- End diff --
I'm OK with this, but it would be cleaner to make
`fileInputDStream.batchTimeToSelectedFiles` a val and reuse it, and keep the
open brace with `synchronized`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
