Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/11235#discussion_r53670314
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashJoin.scala ---
@@ -126,11 +126,11 @@ trait HashJoin {
while (currentHashMatches == null && streamIter.hasNext) {
currentStreamedRow = streamIter.next()
val key = joinKeys(currentStreamedRow)
- if (!key.anyNull) {
- currentHashMatches = hashedRelation.get(key)
- if (currentHashMatches != null) {
- currentMatchPosition = 0
- }
+ // We do filtering null keys by inserting a Filter before
inner join,
--- End diff --
The execution engines correctness should not be predicated on specific
optimizations. That is *really* tight coupling. If you want to optimize code
generation for null handling you should do it based on signals like `nullable`
and not on undocumented, implicit contracts between components.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
