Github user yinxusen commented on the pull request:
https://github.com/apache/spark/pull/11116#issuecomment-187359474
@keypointt Most of the codes look good. However, there are still 3 major
issues to solve:
1. According to PEP8 code style of Python, the imports should be arranged
in [this format](http://legacy.python.org/dev/peps/pep-0008/#imports). Also,
consider for our `# $example on$` and `# $example off$` groups, we should
arrange those imports carefully.
2. Some of the codes have outputs to directories. However, we shouldn't
give the same name for all codes. Change those directory names like the format:
`./target/org.apache.spark.xxx(class name)/xxxModel`. Many code files will be
involved, you need to find all of them.
3. After 1 and 2, you need to merge your branch with the latest master,
since there are conflicts that prevent the auto-merging.
And also, please scrutinize other PRs for the three issues.
Thanks for working on this!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
