Github user nongli commented on a diff in the pull request:
https://github.com/apache/spark/pull/10705#discussion_r53683591
--- Diff: core/src/main/scala/org/apache/spark/CacheManager.scala ---
@@ -136,7 +147,13 @@ private[spark] class CacheManager(blockManager:
BlockManager) extends Logging {
*/
blockManager.putIterator(key, values, level, tellMaster = true,
effectiveStorageLevel)
blockManager.get(key) match {
- case Some(v) => v.data.asInstanceOf[Iterator[T]]
+ case Some(v) =>
--- End diff --
What's the consequence of forgetting to release? Does it get caught
somewhere else and released as a catch all? Similar to the other comments, this
makes it seem like a try {} finally{} is needed after the get(key).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
