Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/11313#discussion_r53731184
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala ---
@@ -579,7 +579,7 @@ class SQLContext private[sql](
val className = beanClass.getName
val beanInfo = Introspector.getBeanInfo(beanClass)
val rows = SQLContext.beansToRows(data.asScala.iterator, beanInfo,
attrSeq)
- DataFrame(self, LocalRelation(attrSeq, rows.toSeq))
+ DataFrame(self, LocalRelation(attrSeq, rows.toArray))
--- End diff --
yah I know we need to materialize anyways (toSeq forces that too on
Iterators) - but I meant more the cost of copying all the objects to an array
(see
https://github.com/scala/scala/blob/v2.11.1/src/library/scala/collection/TraversableOnce.scala#L269
) so maybe only calling toArray if necessary would be worth while (but perhaps
not).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
