Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/11063#discussion_r53750100
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRelation.scala
---
@@ -45,7 +47,8 @@ private[sql] object JDBCRelation {
* incorrect values may cause the partitioning to be poor, but no data
* will fail to be represented.
*/
- def columnPartition(partitioning: JDBCPartitioningInfo):
Array[Partition] = {
+ def columnPartition(partitioning: JDBCPartitioningInfo,
+ schema: StructType, url: String): Array[Partition] = {
--- End diff --
can you add some documentation to this function to explain the parameters?
just do them with @param
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
