Github user dragos commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11272#discussion_r53802880
  
    --- Diff: 
network/shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/BlockTransferMessage.java
 ---
    @@ -40,7 +41,8 @@
     
       /** Preceding every serialized message is its type, which allows us to 
deserialize it. */
       public static enum Type {
    -    OPEN_BLOCKS(0), UPLOAD_BLOCK(1), REGISTER_EXECUTOR(2), 
STREAM_HANDLE(3), REGISTER_DRIVER(4);
    +    OPEN_BLOCKS(0), UPLOAD_BLOCK(1), REGISTER_EXECUTOR(2), 
STREAM_HANDLE(3), REGISTER_DRIVER(4),
    +    HEARTBEAT(5);
    --- End diff --
    
    Thanks @bbossy for testing this. the `sbin/start-shuffle-service` wasn't 
removed because we didn't want to break people's startup scripts. The Mesos one 
was added later, with the driver connection, etc. Something to be removed in 
2.0!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to