Github user nongli commented on a diff in the pull request:
https://github.com/apache/spark/pull/10705#discussion_r53875856
--- Diff:
core/src/main/scala/org/apache/spark/network/netty/NettyBlockRpcServer.scala ---
@@ -65,7 +65,11 @@ class NettyBlockRpcServer(
val level: StorageLevel =
serializer.newInstance().deserialize(ByteBuffer.wrap(uploadBlock.metadata))
val data = new
NioManagedBuffer(ByteBuffer.wrap(uploadBlock.blockData))
- blockManager.putBlockData(BlockId(uploadBlock.blockId), data,
level)
+ val blockId = BlockId(uploadBlock.blockId)
+ val putSucceeded = blockManager.putBlockData(blockId, data, level)
--- End diff --
You seem to do this in a bunch of places, perhaps consider the switched
semantics that put does not retain the lock by default. Not sure if this is
better, something to think about for later.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
