Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/11260#discussion_r53888103
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/JoinOptimizationSuite.scala
---
@@ -92,4 +92,30 @@ class JoinOrderSuite extends PlanTest {
comparePlans(optimized,
analysis.EliminateSubqueryAliases(correctAnswer))
}
+
+ test("broadcasthint sets relation statistics to smallest value") {
+ val input = LocalRelation('key.int, 'value.string)
+
+ val query =
+ Project(Seq($"x.key", $"y.key"),
+ Join(
+ SubqueryAlias("x", input),
+ BroadcastHint(SubqueryAlias("y", input)), Inner, None)).analyze
+
+ val optimized = Optimize.execute(query)
+
+ val expected =
+ Project(Seq($"x.key", $"y.key"),
+ Join(
+ Project(Seq($"x.key"), SubqueryAlias("x", input)),
+ Project(Seq($"y.key"),
+ BroadcastHint(SubqueryAlias("y", input))),
+ Inner, None)).analyze
+
+ comparePlans(optimized, expected)
+
+ assert(optimized.collect {
+ case b @ BroadcastHint(_) if b.statistics.sizeInBytes == 1 => 1
--- End diff --
Because it seems we can't import CanBroadcast into this test, I do update
according to your comment with a little change. Please see if it is appropriate
now. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
