Github user tanwanirahul commented on a diff in the pull request:
https://github.com/apache/spark/pull/11322#discussion_r53905064
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/evaluation/RegressionMetrics.scala
---
@@ -109,6 +111,14 @@ class RegressionMetrics @Since("2.0.0") (
}
/**
+ * @return The root mean squared log error.
+ */
+ @Since("2.0.0")
+ def rootMeanSquaredLogError: Double = {
--- End diff --
@srowen Thanks for the comments. I have made the first two changes you
asked for. On the extra computation side, would you rather prefer to have
second pass over the data only if the RootMeanSquaredLogError has been called?
If so, I would be happy to push that change. Or if you want to suggest any
better solution, it would be interesting to know.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
