Github user chtyim commented on a diff in the pull request:
https://github.com/apache/spark/pull/11337#discussion_r53968653
--- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
@@ -537,9 +537,14 @@ private[spark] class Client(
sys.env.get(envKey).foreach { path =>
val dir = new File(path)
if (dir.isDirectory()) {
- dir.listFiles().foreach { file =>
- if (file.isFile && !hadoopConfFiles.contains(file.getName())) {
- hadoopConfFiles(file.getName()) = file
+ val files = dir.listFiles()
+ if (files == null) {
+ logWarning("Failed to list files under directory " + dir)
--- End diff --
According to the Java API doc, it returns empty array if the directory is
empty. It only returns null if it is not a directory or have IO error
(permission issue). Without logging a warning, we might be silently ignoring
misconfiguration.
Ref: https://docs.oracle.com/javase/7/docs/api/java/io/File.html#listFiles()
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
