GitHub user proflin opened a pull request:

    https://github.com/apache/spark/pull/11368

    [SPARK-13468][Web UI] Fix a corner case where the page UI should show DAG 
but it doesn't show

    When uses clicks more than one time on any stage in the DAG graph on the 
*Job* web UI page, many new *Stage* web UI pages are opened, but only half of 
their DAG graphs are expanded.
    
    After this PR's fix, every newly opened *Stage* page's DAG graph is 
expanded.
    
    Before:
    
![](https://cloud.githubusercontent.com/assets/15843379/13279144/74808e86-db10-11e5-8514-cecf31af8908.png)
    
    
    After:
    
![](https://cloud.githubusercontent.com/assets/15843379/13279145/77ca5dec-db10-11e5-9457-8e1985461328.png)
    
    ## What changes were proposed in this pull request?
    
    - Removed the `expandDagViz` parameter for _Stage_ page and related codes
    - Added a `onclick` function setting `expandDagVizArrowKey(false)` as `true`
    
    ## How was this patch tested?
    
    Manual tests (with this fix) to verified this fix work:
    - clicked many times on _Job_ Page's DAG Graph → each newly opened Stage 
page's DAG graph is expanded
    
    Manual tests (with this fix) to verified this fix do not break features we 
already had:
    - refreshed many times for a same _Stage_ page (whose DAG already expanded) 
→ DAG remained expanded upon every refresh
    - refreshed many times for a same _Stage_ page (whose DAG unexpanded) → 
DAG remained unexpanded upon every refresh
    - refreshed many times for a same _Job_ page (whose DAG already expanded) 
→ DAG remained expanded upon every refresh
    - refreshed many times for a same _Job_ page (whose DAG unexpanded) → DAG 
remained unexpanded upon every refresh

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/proflin/spark SPARK-13468

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/11368.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #11368
    
----
commit 1a2b295a5c3d0775f4ea7b8858754867ffebfee3
Author: Liwei Lin <[email protected]>
Date:   2016-02-25T06:13:49Z

    [SPARK-13468][WebUI] Fix a corner case where the page UI should show DAG 
but it doesn't show

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to