Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/11348#discussion_r54086268
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -804,7 +804,9 @@ object SimplifyFilters extends Rule[LogicalPlan] {
*/
object PushPredicateThroughProject extends Rule[LogicalPlan] with
PredicateHelper {
def apply(plan: LogicalPlan): LogicalPlan = plan transform {
- case filter @ Filter(condition, project @ Project(fields, grandChild))
=>
+ case filter @ Filter(condition, project @ Project(fields, grandChild))
+ if fields.forall(_.deterministic) =>
--- End diff --
how about we add some comments to explain why we can't push down filter
through project with non-deterministic fields? e.g. number of input row is also
an implicit input for non-deterministic expressions, push down filter will
break it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
