Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/1538#discussion_r15316820
--- Diff:
core/src/main/scala/org/apache/spark/deploy/worker/CommandUtils.scala ---
@@ -62,20 +62,23 @@ object CommandUtils extends Logging {
val joined =
command.libraryPathEntries.mkString(File.pathSeparator)
Seq(s"-Djava.library.path=$joined")
} else {
- Seq()
+ Seq()
}
val permGenOpt = Seq("-XX:MaxPermSize=128m")
+ // Convert Spark properties to java system properties
+ val sparkOpts = command.sparkProps.map { case (k, v) => s"-D$k=$v" }
--- End diff --
Not super important, but Yarn only uses system properties for configs
needed to open the akka connection and then transfer the whole config. See:
https://github.com/apache/spark/blob/master/yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ExecutorRunnableUtil.scala#L65
Might be worth doing the same here, or coalescing that logic somewhere.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
