Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/11263#issuecomment-188989692
@zhengruifeng I marked a few places. Please update your code or it is
easier for others to review. I don't see any unit tests in our PR. Maybe you
forget to include it in your commit. You should add them back to test the
feature you implemented.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
