Github user chenghao-intel commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11101#discussion_r54167619
  
    --- Diff: 
streaming/src/main/scala/org/apache/spark/streaming/scheduler/JobGenerator.scala
 ---
    @@ -123,6 +126,15 @@ class JobGenerator(jobScheduler: JobScheduler) extends 
Logging {
             timedOut
           }
     
    +      // generate one more batch to make sure RDD in lastJob is 
checkpointed. As an performance
    +      // optimization, if the latest info has been checkpointed in last 
batch, there is no need
    +      // to run another round. "isCheckpointMissedLastTime" method here is 
in charge of collect
    +      // such information from every DStream recursively.
    +      if (!jobScheduler.receiverTracker.hasUnallocatedBlocks &&
    +        ssc.graph.isCheckpointMissedLastTime) {
    +        Thread.sleep(ssc.graph.batchDuration.milliseconds)
    +      }
    --- End diff --
    
    I just wonder if we can add a double check if the last mini batch finish, 
otherwise, at least we can add a warning log.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to