Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10319#discussion_r54175315
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/CoarseMesosSchedulerBackend.scala
---
@@ -364,7 +379,29 @@ private[spark] class CoarseMesosSchedulerBackend(
}
override def stop() {
- super.stop()
+ // Make sure we're not launching tasks during shutdown
+ stateLock.synchronized {
+ if (stopCalled) {
+ logWarning("Stop called multiple times, ignoring")
+ return
+ }
+ stopCalled = true
+ super.stop()
+ }
+ // Wait for executors to report done, or else mesosDriver.stop() will
forcefully kill them.
+ // See SPARK-12330
+ val stopwatch = new Stopwatch()
--- End diff --
This Stopwatch constructor was deprecated in newer versions of Guava
(https://github.com/google/guava/commit/fd0cbc2c5c90e85fb22c8e86ea19630032090943).
In order to work around this issue, I'd like to remove this use of `Stopwatch`
since we don't use it anywhere else and it doesn't seem to be buying us a whole
lot in the way that it's used here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
