Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11408#discussion_r54333559
  
    --- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
    @@ -60,6 +60,51 @@ private[spark] object CallSite {
       val empty = CallSite("", "")
     }
     
    +/** An utility class to map short compression codec names to qualified 
ones. */
    +private[spark] class ShortCompressionCodecNameMapper {
    --- End diff --
    
    I agree with standardizing names, but this seems like a lot of 
over-engineering, with abstract classes and whatnot just to attempt to make 
some keys consistent. I think this makes it harder to understand, and would 
stick to standardizing the keys.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to