Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/10842#discussion_r54345055
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/orc/OrcRelation.scala ---
@@ -162,6 +162,10 @@ private[sql] class OrcRelation(
extends HadoopFsRelation(maybePartitionSpec, parameters)
with Logging {
+ /* org.apache.orc contains OrcConf which can be used later */
+ private[sql] val ORC_BLOOM_FILTER_COLUMNS = "orc.bloom.filter.columns"
--- End diff --
it is really confusing to have ORC_BLOOM_FILTER_COLUMNS and
orcBloomFilterCols in the same class.
I'd just inline the string in orcBloomFilterCols. Same for
orcBloomFilterFpp.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
