Github user liancheng commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11421#discussion_r54368021
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala 
---
    @@ -621,12 +621,23 @@ class DatasetSuite extends QueryTest with 
SharedSQLContext {
           ds.filter(_ => true),
           Some(1), Some(2), Some(3))
       }
    +
    +  test("SPARK-13540 add Scala object to OuterScopes") {
    +    OuterScopes.addOuterScope(OuterObject)
    --- End diff --
    
    Oh, at first I got a wrong fix for this issue (see the first commit).  I 
thought the problem was that when adding the Scala object into `OuterScopes`, 
the class name without the `$` suffix should be added. Later I found I was 
wrong, but forgot to remove this line. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to