Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/11426#issuecomment-190122926
I like this -- I assume `common` is for modules that don't even depend on
Spark Core and could even be separated from Spark. That seems true of both of
these, so, OK.
The next change I'd suggest is putting `extras/*` into `external`, and
likewise for both `docker*` modules.
The only weird thing there is that `java8-tests` isn't exactly "external".
I suppose it goes away as soon as Spark requires Java 8, so if it's odd, at
least it won't last too long.
I'd also like to unify the various "config / build / binary" dirs, but
that's going to be a little more disruptive or need more discussion about the
theory.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
