Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/11391#discussion_r54451555
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/BufferedRowIterator.java
---
@@ -64,7 +66,16 @@ protected void append(InternalRow row) {
* If it returns true, the caller should exit the loop (return from
processNext()).
*/
protected boolean shouldStop() {
- return !currentRows.isEmpty();
+ return !currentRows.isEmpty() || stopEarly;
--- End diff --
I think we could only override `shouldStop()` for Limit, so we won't add a
branch when we don't have Limit.
```
ctx.addFunction("shouldStop", """
protected boolean shouldStop() {
return !currentRows.isEmpty() || stopEarly;
}""")
```
Please be care full that we can't have two `shouldStop()` in generated
class.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
