Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/11391#discussion_r54529510
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/WholeStageCodegenSuite.scala
---
@@ -78,4 +78,21 @@ class WholeStageCodegenSuite extends SparkPlanTest with
SharedSQLContext {
p.asInstanceOf[WholeStageCodegen].plan.isInstanceOf[Sort]).isDefined)
assert(df.collect() === Array(Row(1), Row(2), Row(3)))
}
+
+ test("Limit should be included in WholeStageCodegen") {
+ val df = sqlContext.range(10000).limit(100).sort(col("id"))
+ val plan = df.queryExecution.executedPlan
+
+ assert(plan.find(p =>
+ p.isInstanceOf[WholeStageCodegen] &&
+ p.asInstanceOf[WholeStageCodegen].plan.isInstanceOf[Sort] &&
--- End diff --
Yeah, because we can't leave limit as last operator otherwise it will
transform to collect limit, so I add a sort here. I will remove it once I am
back to laptop (few hours later).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
