Github user mateiz commented on a diff in the pull request:
https://github.com/apache/spark/pull/1165#discussion_r15331108
--- Diff: core/src/main/scala/org/apache/spark/storage/MemoryStore.scala ---
@@ -215,7 +361,10 @@ private class MemoryStore(blockManager: BlockManager,
maxMemory: Long)
*
* Return whether there is enough free space, along with the blocks
dropped in the process.
*/
- private def ensureFreeSpace(blockIdToAdd: BlockId, space: Long):
ResultWithDroppedBlocks = {
+ private def ensureFreeSpace(
+ blockIdToAdd: BlockId,
+ space: Long,
+ unrolling: Boolean = false): ResultWithDroppedBlocks = {
--- End diff --
If you want a different calculation of how much space to ensure, it would
be better to just pass a different value of "space" when we're unrolling. That
way this method always does the same thing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
