Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/11455#discussion_r54663197
--- Diff:
core/src/main/scala/org/apache/spark/deploy/master/ApplicationInfo.scala ---
@@ -69,7 +69,11 @@ private[spark] class ApplicationInfo(
appUIUrlAtHistoryServer = None
}
- private def newExecutorId(useID: Option[Int] = None): Int = {
+ /**
+ * If `useID` is empty, allocate and return a new executor id.
Otherwise, update `nextExecutorId`
+ * if necessary and return `useID.get`.
+ */
+ private def getOrCreateExecutorId(useID: Option[Int] = None): Int = {
--- End diff --
Renamed this method as it's confusing. It may just return the executor id.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
