Github user kayousterhout commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1561#discussion_r15331519
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/Stage.scala ---
    @@ -56,6 +58,16 @@ private[spark] class Stage(
       val numPartitions = rdd.partitions.size
       val outputLocs = Array.fill[List[MapStatus]](numPartitions)(Nil)
       var numAvailableOutputs = 0
    +
    +  /** List of jobs that this stage belong to. */
    +  val jobIds = new HashSet[Int]
    +  /** For stages that are the final (consists of only ResultTasks), link 
to the ActiveJob. */
    +  var resultOfJob: Option[ActiveJob] = None
    +  var pendingTasks: Option[HashSet[Task[_]]] = None
    --- End diff --
    
    Why use an option here, as opposed to just a (possibly empty) hash set?  
The option makes many of the accesses more clumsy.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to