Github user pwendell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1188#discussion_r15332185
  
    --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StageTable.scala ---
    @@ -99,19 +99,30 @@ private[ui] class StageTableBase(
             {s.name}
           </a>
     
    +    val cachedRddInfos = s.rddInfos.filter(_.numCachedPartitions > 0)
         val details = if (s.details.nonEmpty) {
           <span 
onclick="this.parentNode.querySelector('.stage-details').classList.toggle('collapsed')"
                 class="expand-details">
    -        +show details
    -      </span>
    -      <pre class="stage-details collapsed">{s.details}</pre>
    +        +call stack
    +      </span> ++
    +      <div class="stage-details collapsed">
    +        {if (cachedRddInfos.nonEmpty) {
    +          <strong>Persisted RDD:</strong> ++
    +          cachedRddInfos.map { i =>
    +            <a 
href={"%s/storage/rdd?id=%d".format(UIUtils.prependBaseUri(basePath), i.id)}>
    --- End diff --
    
    I tested this locally and it would be good to pull this onto one line, 
because otherwise the hyperlink renders with a space at the beginning. If you 
need to violate the style guidelines you can disable scalastyle using 
`//scalastyle off` and `//scalastyle on` (see where we do this elsewhere in the 
UI code).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to