Github user MLnick commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10607#discussion_r54697592
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/ml/regression/DecisionTreeRegressor.scala 
---
    @@ -87,6 +87,14 @@ final class DecisionTreeRegressor @Since("1.4.0") 
(@Since("1.4.0") override val
         trees.head.asInstanceOf[DecisionTreeRegressionModel]
       }
     
    +  /** (private[ml]) Train a decision tree on an RDD */
    +  private[ml] def train(data: RDD[LabeledPoint],
    --- End diff --
    
    This seems fine for now as it is `private`. The main idea with this PR will 
be to start the migration. As part of the remaining steps in 
[SPARK-12326](https://issues.apache.org/jira/browse/SPARK-12326), there should 
be plenty of opportunity to clean things up.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to