GitHub user BryanCutler opened a pull request:

    https://github.com/apache/spark/pull/11476

    [SPARK-13625][PYSPARK][ML] Added a check to see if an attribute is a 
property when getting param list

    ## What changes were proposed in this pull request?
    
    Added a check in pyspark.ml.param.Param.params() to see if an attribute is 
a property (decorated with `@property`) before checking if it is a `Param` 
instance.  This prevents the property from being invoked to 'get' this 
attribute, which could possibly cause an error. 
    
    
    ## How was this patch tested?
    
    Ran pyspark-ml test before fix that will trigger an error, and again after 
the fix to verify that the error was resolved and the method was working 
properly.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/BryanCutler/spark 
pyspark-ml-property-attr-SPARK-13625

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/11476.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #11476
    
----
commit 21b506e8c9e526c8e6c7bc6134285316a6becfbc
Author: Bryan Cutler <[email protected]>
Date:   2016-03-02T23:05:34Z

    [SPARK-13625] Added a check to see if an attribute is a property before 
checking if is a Param instance

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to