Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/11283#issuecomment-191581961
@cloud-fan Thank you for your detailed reviews!
Actually, I have a general question about `toSQL`. When writing the
prototype of this PR, I used a different way, similar to what you said above.
Later, I am afraid any assumption I made is dangerous. In the future, if we
introduce another external SQL/DataFrame API, which could generate similar
plans. Then, a simplified solution might generate a wrong SQL. That is the
reason why the commit of this PR is trying to reverse the rule of
`ResolveGroupingAnalytics` step by step.
You know, multi-distinct and windows are more complex when doing SQL
generation. Which way is preferred in your opinion? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
