Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11283#discussion_r54842401
  
    --- Diff: 
sql/hive/src/main/scala/org/apache/spark/sql/hive/SQLBuilder.scala ---
    @@ -85,6 +86,9 @@ class SQLBuilder(logicalPlan: LogicalPlan, sqlContext: 
SQLContext) extends Loggi
         case p: Project =>
           projectToSQL(p, isDistinct = false)
     
    +    case a @ Aggregate(_, _, e @ Expand(_, _, p: Project)) =>
    --- End diff --
    
    we can add a safe guard here, only handle it as grouping set when `p.output 
== p.child.output ++ a.groupingExpressions`. (`==` is wrong here as nullability 
may differ, we can add a `sameOutput` method that use `semanticEquals`)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to