GitHub user JoshRosen opened a pull request:
https://github.com/apache/spark/pull/11502
[SPARK-13659] Refactor BlockStore put*() APIs to remove returnValues
In preparation for larger refactoring, this patch removes the confusing
`returnValues` option from the BlockStore put() APIs: returning the value is
only useful in one place (caching) and in other situations, such as block
replication, it's simpler to put() and then get().
As part of this change, I needed to refactor `BlockManager.doPut()`'s block
replication code. I also changed `doPut()` to access the memory and disk stores
directly rather than calling them through the BlockStore interface; this is in
anticipation of a followup patch to remove the BlockStore interface so that the
disk store can expose a binary-data-oriented API which is not concerned with
Java objects or serialization.
These changes should be covered by the existing storage unit tests. The
best way to review this patch is probably to look at the individual commits,
all of which are small and have useful descriptions to guide the review.
/cc @davies for review.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/JoshRosen/spark remove-returnvalues
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/11502.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #11502
----
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
