GitHub user yanboliang opened a pull request:
https://github.com/apache/spark/pull/11513
[ML] testEstimatorAndModelReadWrite should call checkModelData
## What changes were proposed in this pull request?
Although we defined ```checkModelData``` in ```read/write``` test of ML
estimators/models and pass it to ```testEstimatorAndModelReadWrite```,
```testEstimatorAndModelReadWrite``` omits to call ```checkModelData``` to
check the equality of model data.
So actually we did not run the check of model data equality for all test
cases currently, we should fix it.
cc @jkbradley @mengxr
## How was this patch tested?
No new unit test, should pass the exist ones.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yanboliang/spark ml-check-model-data
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/11513.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #11513
----
commit 8f95454176b289c886f3eeaa82af0401541663d1
Author: Yanbo Liang <[email protected]>
Date: 2016-03-04T06:33:04Z
testEstimatorAndModelReadWrite should call checkModelData
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
