Github user liancheng commented on the pull request:

    https://github.com/apache/spark/pull/11283#issuecomment-192232983
  
    LGTM except a few comments. Thanks for donging this!
    
    Would you please run `HiveCompatibilitySuite` locally and check 
`sql/hive/target/unit-tests.log` to confirm that all queries with grouping set 
are correctly generated? It takes about 10~15 min to run the suite. I found 
that Jenkins skipped this suite.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to