Github user nchammas commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11522#discussion_r55048212
  
    --- Diff: dev/make-distribution.sh ---
    @@ -29,7 +29,7 @@ set -e
     set -x
     
     # Figure out where the Spark framework is installed
    -SPARK_HOME="$(cd "`dirname "$0"`"; pwd)"
    +SPARK_HOME="$(cd "`dirname "$0"`/.."; pwd)"
    --- End diff --
    
    Just a heads up: This is breaking change for tools like spark-ec2 and 
[Flintrock](https://github.com/nchammas/flintrock) which automatically build 
Spark.
    
    I think it's totally OK since 1) this is a developer feature, and 2) this 
is part of the 2.0 update. Just wanted to call that out.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to