Github user sameeragarwal commented on a diff in the pull request:
https://github.com/apache/spark/pull/11511#discussion_r55080364
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/QueryPlanner.scala
---
@@ -26,8 +28,28 @@ import org.apache.spark.sql.catalyst.trees.TreeNode
* be used for execution. If this strategy does not apply to the give
logical operation then an
* empty list should be returned.
*/
-abstract class GenericStrategy[PhysicalPlan <: TreeNode[PhysicalPlan]]
extends Logging {
+abstract class GenericStrategy[PhysicalPlan <: TreeNode[PhysicalPlan]]
+ extends PredicateHelper with Logging {
+
def apply(plan: LogicalPlan): Seq[PhysicalPlan]
+
+ // Attempts to re-order the individual conjunctive predicates in an
expression to short circuit
+ // the evaluation of relatively cheaper checks (e.g., checking for
nullability) before others.
+ protected def getReorderedExpression(expr: Expression): Expression = {
+ splitConjunctivePredicates(expr)
+ .sortWith((x, _) => x.isInstanceOf[IsNotNull])
--- End diff --
yes, I was thinking of doing that in the logical plan in a separate PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
