GitHub user dongjoon-hyun opened a pull request:
https://github.com/apache/spark/pull/11527
[SPARK-13686][MLLIB][STREAMING] Add a constructor parameter `reqParam` to
(Streaming)LinearRegressionWithSGD
## What changes were proposed in this pull request?
`LinearRegressionWithSGD` and `StreamingLinearRegressionWithSGD` does not
have `regParam` as their constructor arguments. They just depends on
GradientDescent's default reqParam values.
To be consistent with other algorithms, we had better add them. The same
default value is used.
## How was this patch tested?
Pass the existing unit test.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dongjoon-hyun/spark SPARK-13686
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/11527.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #11527
----
commit ac105ad1f2fa7c990ae62db95103e109bec34f73
Author: Dongjoon Hyun <dongj...@apache.org>
Date: 2016-03-04T21:27:03Z
[SPARK-13686][MLLIB][STREAMING] Add a constructor parameter `reqParam` to
(Streaming)LinearRegressionWithSGD
`LinearRegressionWithSGD` and `StreamingLinearRegressionWithSGD` does not
have `regParam` as their constructor arguments. They just depends on
GradientDescent's default reqParam values.
To be consistent with other algorithms, we had better add them.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
