GitHub user cloud-fan opened a pull request:

    https://github.com/apache/spark/pull/11532

    [SPARK-13694][SQL] QueryPlan.expressions should always include all 
expressions

    ## What changes were proposed in this pull request?
    
    It's weird that expressions don't always have all the expressions in it. 
This PR marks `QueryPlan.expressions` final to forbid sub classes overriding it 
to exclude some expressions. Currently only `Generate` override it, we can use 
`producedAttributes` to fix the unresolved attribute problem for it.
    
    Note that this PR doesn't fix the problem in #11497 
    
    ## How was this patch tested?
    
    existing tests.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cloud-fan/spark generate

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/11532.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #11532
    
----
commit 5aa533bf59fd8b1f1ff8bd0c13b2829a3710f66d
Author: Wenchen Fan <[email protected]>
Date:   2016-03-05T00:36:04Z

    QueryPlan.expressions should always include all expressions

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to