Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11528#discussion_r55118075
  
    --- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
    @@ -2253,13 +2253,38 @@ private[spark] object Utils extends Logging {
       def isDynamicAllocationEnabled(conf: SparkConf): Boolean = {
         val numExecutor = conf.getInt("spark.executor.instances", 0)
         val dynamicAllocationEnabled = 
conf.getBoolean("spark.dynamicAllocation.enabled", false)
    +    val overrideExecutors = 
conf.getBoolean("spark.dynamicAllocation.overrideNumInstances", false)
    --- End diff --
    
    I think this just piles onto the confusion though, with yet another flag to 
control flags. I think this is a documentation issue, and it already generates 
warnings when you set these things together. I personally favor leaving it as 
is.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to