Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/11530#discussion_r55147271
--- Diff:
streaming/src/test/java/org/apache/spark/streaming/JavaAPISuite.java ---
@@ -390,6 +390,7 @@ public void testQueueStream() {
JavaTestUtils.attachTestOutputStream(stream);
List<List<Integer>> result = JavaTestUtils.runStreams(ssc, 3, 3);
Assert.assertEquals(expected, result);
+ jsc.close();
--- End diff --
These types of changes are welcome of course but I think we need to call
`stop()` in the examples, not `close()`. Or at least that's what the others do.
I don't think Coverity will realize that, but that's fine, it's then a false
positive we just resolve as such.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
