Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11505#discussion_r55181294
  
    --- Diff: core/src/main/scala/org/apache/spark/MapOutputTracker.scala ---
    @@ -376,8 +376,6 @@ private[spark] class MapOutputTrackerMaster(conf: 
SparkConf)
        * @param numReducers total number of reducers in the shuffle
        * @param fractionThreshold fraction of total map output size that a 
location must have
        *                          for it to be considered large.
    -   *
    -   * This method is not thread-safe.
    --- End diff --
    
    Are we sure this makes it thread-safe? I agree it seems to resolve a 
problem that could arise when calling this from multiple threads, but I am not 
as clear it solves all of them. I'm OK with removing this if we have no 
particular reason to believe it's not thread-safe at this point.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to